Skip to content

Add Storage Access Framework demos#191

Merged
yrezgui merged 3 commits into
mainfrom
yrezgui/storage-access-framework
Aug 29, 2025
Merged

Add Storage Access Framework demos#191
yrezgui merged 3 commits into
mainfrom
yrezgui/storage-access-framework

Conversation

@yrezgui
Copy link
Copy Markdown
Contributor

@yrezgui yrezgui commented Aug 23, 2024

Migrating and updating storage access framework demos from https://github.com/android/storage-samples

@yrezgui yrezgui marked this pull request as ready for review September 2, 2024 16:31
@calren calren self-requested a review September 5, 2024 16:05
@madebymozart
Copy link
Copy Markdown
Contributor

madebymozart commented Sep 24, 2024

feel free to rebase or merge this as the build issues should be fixed

@yrezgui yrezgui marked this pull request as draft March 10, 2025 17:00
@yrezgui yrezgui marked this pull request as ready for review March 11, 2025 05:42
@yrezgui yrezgui force-pushed the yrezgui/storage-access-framework branch from 932f780 to 0cedaa8 Compare March 12, 2025 14:01
@yrezgui
Copy link
Copy Markdown
Contributor Author

yrezgui commented Mar 21, 2025

/gemini summarize

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Mar 21, 2025

Warning

You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again!

Waham2000
Waham2000 reviewed Jun 11, 2025
View reviewed changes
Comment thread app/src/main/java/com/example/platform/app/SampleDemo.kt
Copy link
Copy Markdown

@Waham2000 Waham2000 Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://githubstatus.com

@yrezgui yrezgui merged commit 90d9bbd into main Aug 29, 2025
2 of 3 checks passed
@alabiaga
Copy link
Copy Markdown
Member

alabiaga commented Sep 15, 2025

This change is causing android manifest merge issues

Error:
uses-sdk:minSdkVersion 21 cannot be smaller than version 34 declared in library [androidx.photopicker:photopicker-compose:1.0.0-alpha01] /Users/alabiaga/.gradle/caches/8.11.1/transforms/247fc706c8a03340f7e50727e73cc0f7/transformed/photopicker-compose-1.0.0-alpha01/AndroidManifest.xml as the library might be using APIs not available in 21
Suggestion: use a compatible library with a minSdk of at most 21,
or increase this project's minSdk version to at least 34,
or use tools:overrideLibrary="androidx.photopicker.compose" to force usage (may lead to runtime failures)

The minSdk version supported for the photopicker lib is 34, should we bump the whole app to that version?

@alabiaga alabiaga mentioned this pull request Sep 15, 2025
Closed
2 tasks
@yrezgui yrezgui deleted the yrezgui/storage-access-framework branch February 2, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calren calren calren approved these changes

@ashnohe ashnohe Awaiting requested review from ashnohe ashnohe is a code owner

@madebymozart madebymozart Awaiting requested review from madebymozart madebymozart is a code owner

@alabiaga alabiaga Awaiting requested review from alabiaga alabiaga is a code owner

+1 more reviewer

@Waham2000 Waham2000 Waham2000 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yrezgui @madebymozart @alabiaga @calren @Waham2000